chore: Add pagination to users.autocomplete endpoint
#30624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4929678 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30624 +/- ##
===========================================
- Coverage 51.28% 47.19% -4.10%
===========================================
Files 811 796 -15
Lines 15078 14879 -199
Branches 2754 2767 +13
===========================================
- Hits 7733 7022 -711
- Misses 6935 7439 +504
- Partials 410 418 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
may I ask for tests? 🙏 |
|
|
|
Closing this as not needed for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Same default functionality is kept, but now allowing client to paginate elements for components where this is required (Like Omnichannel > Forward room modal which uses this component)